I grew up and lived here for 26 years. It was nice throughout the 90's but it changed a lot. The town pool closed. The crime increased slightly but the borough has way too many "police officers" who sit and troll for the slightest infractions. In the middle of the day they fly through town as if there were a murder but if you drive up to the scene all it was was a traffic stop. The housing here is pretty old and looks pretty unappealing. The taxes are ridiculously high because of the "police force" and the public school system there. Home values are very low. I have no idea how the schools got rated a C when Steelton-Highspire school district is one of the worst in the state and may get shut down.
The upside to this town is it's generally quiet. It has a few nice markets and shops. It is close to the river. It has some nice parkland when it's maintained. Not much else going for it.